Re: [PATCH] drivers/net/wan/x25_asy: Fix to make it work

From: Xie He
Date: Tue Jul 14 2020 - 05:55:28 EST


On Tue, Jul 14, 2020 at 1:07 AM -0700
Martin Schiller <ms@xxxxxxxxxx> wrote:
>
> It really seems very strange that this driver seems to contain such
> fundamental errors. I have never used it.
>
> But the explanations and fixes look plausible to me.

Thank you for reviewing this patch, Martin!

Yes, this situation is very strange. I guess not so many people have
tried this driver. The comment of this driver says it doesn't
implement the checksum, which is required by the international
standard. So I guess it can't be used for practical purposes anyway. I
tried this driver because I was personally interested in X.25.