Re: Re: [PATCH] spi: Use clk_prepare_enable and clk_disable_unprepare
From: Qing Zhang
Date: Tue Jul 14 2020 - 08:16:27 EST
> -----Original Messages-----
> From: "Mark Brown" <broonie@xxxxxxxxxx>
> Sent Time: 2020-07-14 17:44:06 (Tuesday)
> To: "Qing Zhang" <zhangqing@xxxxxxxxxxx>
> Cc: linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Xuefeng Li" <lixuefeng@xxxxxxxxxxx>, "Tiezhu Yang" <yangtiezhu@xxxxxxxxxxx>
> Subject: Re: [PATCH] spi: Use clk_prepare_enable and clk_disable_unprepare
>
> On Tue, Jul 14, 2020 at 05:09:14PM +0800, Qing Zhang wrote:
> > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
> > calls as required by common clock framework.
> >
> > Signed-off-by: Qing Zhang <zhangqing@xxxxxxxxxxx>
> > ---
> > drivers/spi/spi-coldfire-qspi.c | 4 ++--
>
> Are you sure that ColdFire uses the common clock framework?
>
> > drivers/spi/spi-omap-uwire.c | 4 ++--
>
> It makes life easier if you send per-driver patches, that makes it
> easier for driver maintainers to review things and means that issues
> with a change in one driver won't hold up another.
Hi Mark,
Thank you for your suggestion.
I will split this patch into two patches and then send v2.
</zhangqing@xxxxxxxxxxx></yangtiezhu@xxxxxxxxxxx></lixuefeng@xxxxxxxxxxx></zhangqing@xxxxxxxxxxx></broonie@xxxxxxxxxx>