Re: [PATCH] btrfs : fix memory leak in add_block_entry

[David Sterba]

On Tue, Jul 07, 2020 at 06:29:08AM -0700, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
> 
> clang static analysis flags this error
> 
> fs/btrfs/ref-verify.c:290:3: warning: Potential leak of memory pointed to by 're' [unix.Malloc]
>                 kfree(be);
>                 ^~~~~
> The problem is in this block of code
> 
> 		if (root_objectid) {
> 			struct root_entry *exist_re;
> 
> 			exist_re = insert_root_entry(&exist->roots, re);
> 			if (exist_re)
> 				kfree(re);
> 		}
> 
> There is no 'else' block freeing when root_objectid == 0
> 
> So add an 'else'
> 
> Fixes: fd708b81d972 ("Btrfs: add a extent ref verify tool")
> 
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Added to misc-next, thanks.