Re: [PATCH v2 05/29] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues
From: Lee Jones
Date: Tue Jul 14 2020 - 10:23:37 EST
On Tue, 14 Jul 2020, Martin K. Petersen wrote:
>
> Lee,
Ah, you are alive. I was beginning to worry. :)
I have more fixes for you, but didn't want to send them until these
have been merged.
> > @@ -3015,9 +3016,8 @@ static void fcoe_ctlr_disc_recv(struct fc_lport *lport, struct fc_frame *fp)
> > fc_frame_free(fp);
> > }
> >
> > -/**
> > +/*
> > * fcoe_ctlr_disc_recv - start discovery for VN2VN mode.
> > - * @fip: The FCoE controller
> > *
> > * This sets a flag indicating that remote ports should be created
> > * and started for the peers we discover. We use the disc_callback
>
> s/fcoe_ctlr_disc_recv/fcoe_ctlr_disc_start/ ?
Yes, I spotted it. Hence my earlier comment to Hannes:
"Look at the function below it (in your local copy). ;)"
Do you want me to fix that up here as well?
--
Lee Jones [æçæ]
Senior Technical Lead - Developer Services
Linaro.org â Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog