Re: [PATCH] checkpatch.pl: Allow '+' in compatible strings

From: Rob Herring
Date: Tue Jul 14 2020 - 13:42:30 EST


On Tue, Jul 14, 2020 at 11:12 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Tue, 2020-07-14 at 10:21 -0600, Rob Herring wrote:
> > On Tue, Jul 14, 2020 at 3:41 AM Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> > > From: Thierry Reding <treding@xxxxxxxxxx>
> > >
> > > The current checks will interpret a '+' character as special because
> > > they use regular expression matching. Escape the '+' character if it
> > > appears in a compatible string.
> >
> > Ugg, looks like c6x really liked using '+'. Might need to be added in
> > schema checks, too. Not sure offhand.
>
> These are the non alphanumeric characters used in .dts and .dtsi files
> with 'compatible=' strings
>
> - 44115
> , 32035
> . 1131
> _ 259
> + 46
> / 18
> ) 5
> ( 5
>
> So it looks like
>
> "("
> ")"
>
> need to be added and escaped too
>
> ?

No, those are 'regulator-compatible' AFAICT which is something else
and deprecated.

Rob