Re: [PATCH] fs/9p: Fix TCREATE's fid in protocol

From: Victor Hsieh
Date: Tue Jul 14 2020 - 17:10:27 EST


Please disregard this patch. I misunderstood the protocol and have
found the actual problem in the hypervisor's 9P implementation. Sorry
about the noise.

On Tue, Jul 14, 2020 at 1:54 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> On Tue, Jul 14, 2020 at 02:12:49PM +0200, Dominique Martinet wrote:
> >
> > > Fixes: 5643135a2846 ("fs/9p: This patch implements TLCREATE for 9p2000.L protocol.")
> > > Signed-off-by: Victor Hsieh <victorhsieh@xxxxxxxxxx>
> > > Cc: stable@xxxxxxxxxxxxxxx
> >
> > (afaiu it is normally frowned upon for developers to add this cc (I can
> > understand stable@ not wanting spam discussing issues left and right
> > before maintainers agreed on them!) ; I can add it to the commit itself
> > if requested but they normally pick most such fixes pretty nicely for
> > backport anyway; I see most 9p patches backported as long as the patch
> > applies cleanly which is pretty much all the time.
> > Please let me know if I understood that incorrectly)
> >
>
> Some people assume this, but the stable maintainers themselves say that Cc'ing
> stable@xxxxxxxxxxxxxxx on in-development patches is fine:
> https://lkml.kernel.org/r/20200423184219.GA80650@xxxxxxxxx
>
> And doing so is pretty much inevitable, since the tag gets picked up by
> 'git send-email'. (Yes, there's also "stable@xxxxxxxxxx", but it's not actually
> what is documented.)
>
> - Eric