Re: [PATCH 7/7] exec: Implement kernel_execve

From: Christoph Hellwig
Date: Wed Jul 15 2020 - 02:42:25 EST


> +static int count_strings_kernel(const char *const *argv)
> +{
> + int i;
> +
> + if (!argv)
> + return 0;
> +
> + for (i = 0; argv[i]; ++i) {
> + if (i >= MAX_ARG_STRINGS)
> + return -E2BIG;
> + if (fatal_signal_pending(current))
> + return -ERESTARTNOHAND;
> + cond_resched();

I don't think we need a fatal_signal_pending and cond_resched() is
needed in each step given that we don't actually do anything.