Re: [PATCH] dmaengine: imx-sdma: remove always true comparisons

From: Fabio Estevam
Date: Wed Jul 15 2020 - 09:17:14 EST


Hi Vinod,

On Wed, Jul 15, 2020 at 10:01 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
>
> sdmac->event_id0 is of type unsigned int and hence can never be less
> than zero. Driver compares this at couple of places with greater than or
> equal to zero, these are always true so should be dropped
>
> drivers/dma/imx-sdma.c:1336:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
> drivers/dma/imx-sdma.c:1637:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>

I have already fixed this problem and you have already applied my patch:
https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/commit/?h=next&id=2f57b8d57673af2c2caf8c2c7bef01be940a5c2c