Re: [PATCH 4.19 15/58] drm: panel-orientation-quirks: Use generic orientation-data for Acer S1003

From: Pavel Machek
Date: Wed Jul 15 2020 - 10:45:56 EST


Hi!

> The Acer S1003 has proper DMI strings for sys-vendor and product-name,
> so we do not need to match by BIOS-date.
>
> This means that the Acer S1003 can use the generic lcd800x1280_rightside_up
> drm_dmi_panel_orientation_data struct which is also used by other quirks.

This is just a cleanup, it does not fix anything. I don't think we
need it in stable.

Best regards,
Pavel

>
> -static const struct drm_dmi_panel_orientation_data acer_s1003 = {
> - .width = 800,
> - .height = 1280,
> - .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> -};
> -
> static const struct drm_dmi_panel_orientation_data asus_t100ha = {
> .width = 800,
> .height = 1280,
> @@ -100,7 +94,7 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
> },
> - .driver_data = (void *)&acer_s1003,
> + .driver_data = (void *)&lcd800x1280_rightside_up,
> }, { /* Asus T100HA */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> --
> 2.25.1
>
>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature