Re: [PATCH] Modified Makefile to print -eudyptula in the version string

From: Nick Desaulniers
Date: Wed Jul 15 2020 - 13:03:05 EST


On Wed, Jul 15, 2020 at 7:26 AM Mritunjay Sharma
<mritunjaysharma394@xxxxxxxxx> wrote:
>
> Signed-off-by: Mritunjay Sharma <mritunjaysharma394@xxxxxxxxx>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 0b5f8538bde5..d7897ce5ab23 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2,7 +2,7 @@
> VERSION = 5
> PATCHLEVEL = 8
> SUBLEVEL = 0
> -EXTRAVERSION = -rc5
> +EXTRAVERSION = -rc5-eudyptula

oh man, I love the Eudyptula challenge. I remember running through it
not too long ago. I don't think you're actually supposed to send this
change though. Anyways, good job, looks like you found the right
reviewers if this is a change we'd actually want to commit.

It's usually expected to have more in the body than just the online
summary and your signoff. A comment review comment is "-ENOCOMMITMSG"
which I think is its own meme.

> NAME = Kleptomaniac Octopus
>
> # *DOCUMENTATION*
> --


--
Thanks,
~Nick Desaulniers