Re: [PATCH 2/2] x86/reboot/quirks: Add ASRock Z170 Extreme4

From: Christoph Hellwig
Date: Wed Jul 15 2020 - 14:12:58 EST


On Mon, Jun 29, 2020 at 09:58:05PM +0100, Simon Arlott wrote:
> If a PCI mode reboot is performed on the ASRock Z170 Extreme4, a power
> cycle will occur. Automatically set the reboot quirk for this to prepare
> for the power off (i.e. stop all disks).
>
> This will only take effect if PCI mode is manually used. It'll be too late
> in the reboot process to prepare for power off if the other reboot methods
> fail.
>
> It is necessary to re-order the processing of DMI checks because this quirk
> must apply even if a reboot= command line parameter is used as that's the
> only way to specify a PCI mode reboot.
>
> Signed-off-by: Simon Arlott <simon@xxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>