Re: ioremap and dma cleanups and fixes for superh (2nd resend)

[Geert Uytterhoeven]

On Wed, Jul 15, 2020 at 6:18 PM John Paul Adrian Glaubitz
<glaubitz@xxxxxxxxxxxxxxxxxxx> wrote:
> On 7/15/20 4:37 PM, John Paul Adrian Glaubitz wrote:
> > Okay, kernel 5.0.0 does not suffer from this bug. So I should be able to bisect
> > this particular issue.
> >
> > I'm glad I don't have to start bisecting with earlier kernels because these
> > won't build easily with my current toolchain based on gcc-9.
> >
> > Will report once I found the bad commit that introduced the problem.
>
> Found the culprit:
>
> c5b27a889da92f4a969d61df77bd4f79ffce57c9 is the first bad commit
> commit c5b27a889da92f4a969d61df77bd4f79ffce57c9
> Author: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Date:   Tue Sep 4 14:45:04 2018 +0200
>
>     sh/tlb: Convert SH to generic mmu_gather
>
>     Generic mmu_gather provides everything SH needs (range tracking and
>     cache coherency).
>
>     No change in behavior intended.
>
>     Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>     Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>     Cc: Andy Lutomirski <luto@xxxxxxxxxx>
>     Cc: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx>
>     Cc: Borislav Petkov <bp@xxxxxxxxx>
>     Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>     Cc: H. Peter Anvin <hpa@xxxxxxxxx>
>     Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>     Cc: Nick Piggin <npiggin@xxxxxxxxx>
>     Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>     Cc: Rich Felker <dalias@xxxxxxxx>
>     Cc: Rik van Riel <riel@xxxxxxxxxxx>
>     Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>     Cc: Will Deacon <will.deacon@xxxxxxx>
>     Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
>     Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
>
>  arch/sh/include/asm/pgalloc.h |   9 +++
>  arch/sh/include/asm/tlb.h     | 130 +-----------------------------------------
>  2 files changed, 10 insertions(+), 129 deletions(-)
>
> CC'ing the author (Peter Zijlstra <peterz@xxxxxxxxxxxxx>).

Oh, we actually discussed that:
https://lore.kernel.org/linux-mm/20191204133454.GW2844@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
but there was no conclusion...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds