Re: [PATCH v5 5/6] arm64: dts: qcom: sc7180: Add interconnects property for GPU
From: Rob Clark
Date: Wed Jul 15 2020 - 14:26:41 EST
On Mon, Jul 13, 2020 at 5:42 AM Akhil P Oommen <akhilpo@xxxxxxxxxxxxxx> wrote:
>
> From: Sharat Masetty <smasetty@xxxxxxxxxxxxxx>
>
> This patch adds the interconnects property to the GPU node. This enables
> the GPU->DDR path bandwidth voting.
>
> Signed-off-by: Sharat Masetty <smasetty@xxxxxxxxxxxxxx>
> Signed-off-by: Akhil P Oommen <akhilpo@xxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 31b9217..a567297 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1470,6 +1470,8 @@
> operating-points-v2 = <&gpu_opp_table>;
> qcom,gmu = <&gmu>;
>
> + interconnects = <&gem_noc MASTER_GFX3D &mc_virt SLAVE_EBI1>;
I suppose this and the 845 dts patch should have:
interconnect-names = "gfx-mem";
(OTOH not having it was a good way to notice a bug in the driver
handling the legacy case without having 'interconnect-names')
BR,
-R
> +
> gpu_opp_table: opp-table {
> compatible = "operating-points-v2";
>
> --
> 2.7.4
>