Re: Re: [PATCH v7 1/8] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controllerãèææïéäçrobherring2@xxxxxxxxxäåã

[èäå]

Hi Rob,

>On Wed, 15 Jul 2020 17:03:39 +0800, Yifeng Zhao wrote:
>> Documentation support for Rockchip RK3xxx NAND flash controllers
>>
>> Signed-off-by: Yifeng Zhao <yifeng.zhao@xxxxxxxxxxxxxx>
>> ---
>>
>> Changes in v7:
>> - Fix some wrong define
>>
>> Changes in v6:
>> - Fix some wrong define
>> - Modified the definition of compatible
>>
>> Changes in v5:
>> - Fix some wrong define.
>> - Add boot-medium define.
>> - Remove some compatible define.
>>
>> Changes in v4:
>> - The compatible define with rkxx_nfc.
>> - Add assigned-clocks.
>> - Fix some wrong defineChanges in.
>>
>> Changes in v3:
>> - Change the title for the dt-bindings.
>>
>> Changes in v2: None
>>
>>Â .../mtd/rockchip,nand-controller.yamlÂÂÂÂÂÂÂÂ | 162 ++++++++++++++++++
>>Â 1 file changed, 162 insertions(+)
>>Â create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
>>
>
>
>My bot found errors running 'make dt_binding_check' on your patch:
>
>/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml: example-0: nand-controller@ff4b0000:reg:0: [0, 4283105280, 0, 16384] is too long
>
>
>See https://patchwork.ozlabs.org/patch/1329325
>
>If you already ran 'make dt_binding_check' and didn't see the above
>error(s), then make sure dt-schema is up to date:
>
>pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
>Please check and re-submit.

make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yamlÂ
 HOSTCC Âscripts/basic/fixdep
 HOSTCC Âscripts/dtc/dtc.o
 HOSTCC Âscripts/dtc/flattree.o
 HOSTCC Âscripts/dtc/fstree.o
 HOSTCC Âscripts/dtc/data.o
 HOSTCC Âscripts/dtc/livetree.o
 HOSTCC Âscripts/dtc/treesource.o
 HOSTCC Âscripts/dtc/srcpos.o
 HOSTCC Âscripts/dtc/checks.o
 HOSTCC Âscripts/dtc/util.o
 LEX   scripts/dtc/dtc-lexer.lex.c
 YACC  Âscripts/dtc/dtc-parser.tab.[ch]
 HOSTCC Âscripts/dtc/dtc-lexer.lex.o
 HOSTCC Âscripts/dtc/dtc-parser.tab.o
 HOSTCC Âscripts/dtc/yamltree.o
 HOSTLD Âscripts/dtc/dtc
 CHKDT  Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
 SCHEMA ÂDocumentation/devicetree/bindings/processed-schema-examples.yaml
 DTC   Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml
 CHECK  Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml
/home/yifeng/work/linux/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml: example-0: nand-controller@ff4b0000:reg:0: [0, 4283105280, 0, 16384] is too long

I already ran the "make dt_binding_check" before submit this patch and found this issue.
The dts examples is for RK3308, ARCH=arm64, and the reg define is correct.
I thought there was something wrong with the checkï or something configuration I missed.
Please give me some suggestions.


diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
index 493705a55638..b9d7a8c79402 100644
--- a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
+++ b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
@@ -132,7 +132,7 @@ examples:
  Ânfc: nand-controller@ff4b0000 {
   Âcompatible = "rockchip,rk3308-nfc",
          "rockchip,rv1108-nfc";
- Â Â Âreg = <0x0 0xff4b0000 0x0 0x4000>;
+ Â Â Âreg = <0xff4b0000 0x4000>;
   Âinterrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
   Âclocks = <&cru HCLK_NANDC>, <&cru SCLK_NANDC>;
   Âclock-names = "ahb", "nfc";

make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yamlÂ
 SCHEMA ÂDocumentation/devicetree/bindings/processed-schema-examples.yaml
 CHKDT  Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
 DTC   Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml
 CHECK  Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dt.yaml

yifeng.zhao