Re: [PATCH] net: smc91x: Fix possible memory leak in smc_drv_probe()

From: Markus Elfring
Date: Thu Jul 16 2020 - 02:21:06 EST


> If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev)
> should be called to free the ndev created earlier. Otherwise, a memleak
> will occur.

* Will it be nicer to use the term âmemory leakâ also in this change description?

* Would another imperative wording be preferred for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=f8456690ba8eb18ea4714e68554e242a04f65cff#n151

Regards,
Markus