Re: [PATCH 10/14] spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc

From: Michal Simek
Date: Thu Jul 16 2020 - 03:21:02 EST




On 15. 07. 20 17:06, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavecs' not described in 'zynqmp_gqspi_selectslave'
> drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavebus' not described in 'zynqmp_gqspi_selectslave'
> drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashcs' description in 'zynqmp_gqspi_selectslave'
> drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashbus' description in 'zynqmp_gqspi_selectslave'
> drivers/spi/spi-zynqmp-gqspi.c:902: warning: Function parameter or member 'dev' not described in 'zynqmp_qspi_suspend'
> drivers/spi/spi-zynqmp-gqspi.c:902: warning: Excess function parameter '_dev' description in 'zynqmp_qspi_suspend'
>
> Cc: Michal Simek <michal.simek@xxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/spi/spi-zynqmp-gqspi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
> index 811c97a7c8589..e17a201252557 100644
> --- a/drivers/spi/spi-zynqmp-gqspi.c
> +++ b/drivers/spi/spi-zynqmp-gqspi.c
> @@ -197,8 +197,8 @@ static inline void zynqmp_gqspi_write(struct zynqmp_qspi *xqspi, u32 offset,
> /**
> * zynqmp_gqspi_selectslave: For selection of slave device
> * @instanceptr: Pointer to the zynqmp_qspi structure
> - * @flashcs: For chip select
> - * @flashbus: To check which bus is selected- upper or lower
> + * @slavecs: For chip select
> + * @slavebus: To check which bus is selected- upper or lower
> */
> static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
> u8 slavecs, u8 slavebus)
> @@ -892,7 +892,7 @@ static int zynqmp_qspi_start_transfer(struct spi_master *master,
>
> /**
> * zynqmp_qspi_suspend: Suspend method for the QSPI driver
> - * @_dev: Address of the platform_device structure
> + * @dev: Address of the platform_device structure
> *
> * This function stops the QSPI driver queue and disables the QSPI controller
> *
>

Reviewed-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks,
Michal