[PATCH -next] pktcdvd: Convert to DEFINE_SHOW_ATTRIBUTE

From: Qinglang Miao
Date: Thu Jul 16 2020 - 05:02:16 EST


From: Liu Shixin <liushixin2@xxxxxxxxxx>

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Liu Shixin <liushixin2@xxxxxxxxxx>
---
drivers/block/pktcdvd.c | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index c81f63714..6a79770db 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -452,23 +452,12 @@ static void pkt_sysfs_cleanup(void)

*******************************************************************/

-static int pkt_debugfs_seq_show(struct seq_file *m, void *p)
+static int pkt_debugfs_show(struct seq_file *m, void *p)
{
return pkt_seq_show(m, p);
}

-static int pkt_debugfs_fops_open(struct inode *inode, struct file *file)
-{
- return single_open(file, pkt_debugfs_seq_show, inode->i_private);
-}
-
-static const struct file_operations debug_fops = {
- .open = pkt_debugfs_fops_open,
- .read_iter = seq_read_iter,
- .llseek = seq_lseek,
- .release = single_release,
- .owner = THIS_MODULE,
-};
+DEFINE_SHOW_ATTRIBUTE(pkt_debugfs);

static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
{
@@ -479,7 +468,7 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
return;

pd->dfs_f_info = debugfs_create_file("info", 0444,
- pd->dfs_d_root, pd, &debug_fops);
+ pd->dfs_d_root, pd, &pkt_debugfs_fops);
}

static void pkt_debugfs_dev_remove(struct pktcdvd_device *pd)
--
2.17.1