Re: [PATCH v3] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

From: B K Karthik
Date: Thu Jul 16 2020 - 10:28:23 EST


On Thu, Jul 16, 2020 at 10:25 AM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Jul 16, 2020 at 10:17:47AM -0400, B K Karthik wrote:
> > fixed sparse warnings by adding a cast in assignment from
> > void [noderef] __user * to unsigned int __force *
> > and a reverse cast in argument from
> > unsigned int * to unsigned int __user * .
> >
> > Signed-off-by: B K Karthik <karthik.bk2000@xxxxxxxx>
> > ---
> > drivers/staging/comedi/comedi_fops.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> What changed from previous versions?

As Ian Abbott said "Minor quibble: the reverse cast is actually from
unsigned int * to"

Hence this is a change in the commit description.

>
> That always goes below the --- line.

I did not understand this sir, can you please clarify?

thanks,

karthik