Re: [PATCH] ASoC: meson: add the missed kfree() for axg_card_add_tdm_loopback
From: Mark Brown
Date: Thu Jul 16 2020 - 10:35:02 EST
On Thu, Jul 16, 2020 at 03:29:39PM +0200, Jerome Brunet wrote:
> On Thu 16 Jul 2020 at 15:25, Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx> wrote:
> > axg_card_add_tdm_loopback() misses to call kfree() in an error path. Add
> > the missed function call to fix it.
> >
> > Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style")
> > Signed-off-by: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx>
> Thanks for fixing this.
> Maybe it would be better to use the devm_ variant for the name instead ?
Yes, that should be more robust.
Attachment:
signature.asc
Description: PGP signature