Re: [PATCH V5] drivers/nvme: Add support for ACPI StorageD3Enable property

From: Christoph Hellwig
Date: Thu Jul 16 2020 - 10:39:37 EST


On Mon, Jul 13, 2020 at 01:12:26PM +0200, Rafael J. Wysocki wrote:
> I would write this as
>
> if (fwnode_property_read_u8(acpi_fwnode_handle(adev),
> "StorageD3Enable", &val))
> return false;
>
> return val == 1;
>
> to eliminate the redundant fwnode variable and untangle the last
> checks somewhat.
>
> With that changed please feel free to add
>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Applied to nvme-5.9 with the above fixup.