Re: [PATCH] phy: sun4i-usb: explicitly include gpio/consumer.h

[Randy Dunlap]

On 7/15/20 11:24 PM, Vinod Koul wrote:
> Driver uses GPIO functions but doesn't include the header explcitly. Add
> that to fix build errors when GPIOLIB is disabled.
> 
> drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit
> declaration of function âgpiod_get_value_cansleepâ; did you mean
> âgpio_get_value_cansleepâ? [-Werror=implicit-function-declaration]
> drivers/phy/allwinner/phy-sun4i-usb.c:707:22: error: implicit
> declaration of function âdevm_gpiod_get_optionalâ; did you mean
> âdevm_clk_get_optionalâ? [-Werror=implicit-function-declaration]
> drivers/phy/allwinner/phy-sun4i-usb.c:708:11: error: âGPIOD_INâ
> undeclared (first use in this function); did you mean âGPIOF_INâ?
> drivers/phy/allwinner/phy-sun4i-usb.c:815:21: error: implicit
> declaration of function âgpiod_to_irqâ; did you mean âgpio_to_irqâ?
> [-Werror=implicit-function-declaration]
> 
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

Thanks.

> ---
>  drivers/phy/allwinner/phy-sun4i-usb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
> index 7e09ad6a0b42..585d0a59e712 100644
> --- a/drivers/phy/allwinner/phy-sun4i-usb.c
> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c
> @@ -16,6 +16,7 @@
>  #include <linux/delay.h>
>  #include <linux/err.h>
>  #include <linux/extcon-provider.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/io.h>
>  #include <linux/interrupt.h>
>  #include <linux/kernel.h>
> 


-- 
~Randy