Re: [PATCH v4 13/17] dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'

From: jim . cromie
Date: Thu Jul 16 2020 - 12:50:02 EST


> > @@ -321,6 +321,8 @@ static int parse_linerange(struct ddebug_query *query, const char *first)
> > } else {
> > query->last_lineno = query->first_lineno;
> > }
> > + vpr_info("parsed line %d-%d\n", query->first_lineno,
> > + query->last_lineno);
> > return 0;
> > }
>
> This bit seems like its unrelated to this patch and makes more sense in the
> previous patch, or as separate patch...
>
> Thanks,
>
> -Jason
>

ok, I'll split it out, maybe merge with prior.

Any other tweaks ?
maybe move export last in series ?
how do you feel about changing the pr_fmt
to just mod-name "dynamic_debug" or "dyndbg"

Jim