Re: [PATCH v3 net] net: fec: fix hardware time stamping by external devices

From: Jakub Kicinski
Date: Thu Jul 16 2020 - 14:24:36 EST


On Tue, 14 Jul 2020 19:28:02 +0300 Sergey Organov wrote:
> Fix support for external PTP-aware devices such as DSA or PTP PHY:
>
> Make sure we never time stamp tx packets when hardware time stamping
> is disabled.
>
> Check for PTP PHY being in use and then pass ioctls related to time
> stamping of Ethernet packets to the PTP PHY rather than handle them
> ourselves. In addition, disable our own hardware time stamping in this
> case.
>
> Fixes: 6605b730c061 ("FEC: Add time stamping code and a PTP hardware clock")
> Signed-off-by: Sergey Organov <sorganov@xxxxxxxxx>
> Acked-by: Richard Cochran <richardcochran@xxxxxxxxx>
> Acked-by: Vladimir Oltean <olteanv@xxxxxxxxx>
> ---
>
> v3:
> - Fixed SHA1 length of Fixes: tag
> - Added Acked-by: tags
>
> v2:
> - Extracted from larger patch series
> - Description/comments updated according to discussions
> - Added Fixes: tag

FWIW in the networking subsystem we like the changelog to be part of the
commit.

Applied, and added to the stable queue, thanks!