Re: [PATCH v4 0/2] Syscall User Redirection

From: Kees Cook
Date: Thu Jul 16 2020 - 16:25:48 EST


On Thu, Jul 16, 2020 at 10:22:34PM +0200, Christian Brauner wrote:
> On Thu, Jul 16, 2020 at 01:04:38PM -0700, Kees Cook wrote:
> > On Thu, Jul 16, 2020 at 03:31:39PM -0400, Gabriel Krisman Bertazi wrote:
> > > This is v4 of Syscall User Redirection. The implementation itself is
> > > not modified from v3, it only applies the latest round of reviews to the
> > > selftests.
> > >
> > > __NR_syscalls is not really exported in header files other than
> > > asm-generic for every architecture, so it felt safer to optionally
> > > expose it with a fallback to a high value.
> > >
> > > Also, I didn't expose tests for PR_GET as that is not currently
> > > implemented. If possible, I'd have it supported by a future patchset,
> > > since it is not immediately necessary to support this feature.
> >
> > Thanks! That all looks good to me.
>
> Don't have any problem with this but did this ever get exposure on
> linux-api? This is the first time I see this pop up.

I thought I'd added it to CC in the past, but that might have been other
recent unrelated threads. Does this need a full repost there too, you
think?

--
Kees Cook