Re: [PATCH][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword

From: Geert Uytterhoeven
Date: Fri Jul 17 2020 - 03:18:19 EST


Hi Gustavo,

Thanks for your patch!

On Thu, Jul 16, 2020 at 11:11 PM Gustavo A. R. Silva
<gustavoars@xxxxxxxxxx> wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.

Which unnecessary marking is being removed?
I don't see any.

>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

For the actual patch contents:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds