Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate

From: Frank Lee
Date: Fri Jul 17 2020 - 03:35:50 EST


On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:
>
> On 14/07/2020 09:13, Frank Lee wrote:
> > From: Yangtao Li <frank@xxxxxxxxxxxxxxxxx>
> >
> > For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of
> > calculation. On the other hand, the newer SOC may store other data in
> > the space other than 12bit sensor data. Add mask operation to read data
> > to avoid conversion error.
> >
> > Signed-off-by: Yangtao Li <frank@xxxxxxxxxxxxxxxxx>
> > Reviewed-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
>
> Can you clarify these SoB ?

Previously I used 'Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>',
maybe this should be removed directly?

>
> Frank Lee==Yangtao Li==frank@xxxxxxxxxxxxxxxxx==tiny.windzz@gmail.com ?
>

Yeah.

Yangtao