Re: [PATCH] [SCSI] libsas: add missing newline when printing 'enable' by sysfs

[Xiongfeng Wang]

Hi John,

On 2020/7/17 15:54, John Garry wrote:
> On 17/07/2020 08:36, Xiongfeng Wang wrote:
> 
> Hi,
> 
> I think "scsi: scsi_transport_sas: " would be a better subject prefix, as this
> is not libsas code.
> 
>> When I cat sysfs file 'enable' below 'sas_phy', it displays as follows.
>> It's better to add a newline for easy reading.
>>
>> [root@localhost ~]# cat
>> /sys/devices/pci0000:00/0000:00:0d.0/0000:0f:00.0/host3/phy-3:2/sas_phy/phy-3:2/enable
>>
>> 1[root@localhost ~]#
>>
>> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@xxxxxxxxxx>
> 
> Apart from above,
> Reviewed-by: John Garry <john.garry@xxxxxxxxxx>

Thanks for your review. I will send another version.

Thanks,
Xiongfeng

> 
>> ---
>> Â drivers/scsi/scsi_transport_sas.c | 2 +-
>> Â 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/scsi_transport_sas.c
>> b/drivers/scsi/scsi_transport_sas.c
>> index 182fd25..e443dee 100644
>> --- a/drivers/scsi/scsi_transport_sas.c
>> +++ b/drivers/scsi/scsi_transport_sas.c
>> @@ -563,7 +563,7 @@ static ssize_t do_sas_phy_enable(struct device *dev,
>> Â {
>> ÂÂÂÂÂ struct sas_phy *phy = transport_class_to_phy(dev);
>> Â -ÂÂÂ return snprintf(buf, 20, "%d", phy->enabled);
>> +ÂÂÂ return snprintf(buf, 20, "%d\n", phy->enabled);
>> Â }
>> Â Â static DEVICE_ATTR(enable, S_IRUGO | S_IWUSR, show_sas_phy_enable,
>>
> 
> 
> .