linux-next: build warning after merge of the akpm-current tree

From: Stephen Rothwell
Date: Fri Jul 17 2020 - 06:31:34 EST


Hi all,

After merging the akpm-current tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

mm/vmstat.c:614: warning: "MAX_THRESHOLD" redefined
614 | #define MAX_THRESHOLD 0
|
mm/vmstat.c:172: note: this is the location of the previous definition
172 | #define MAX_THRESHOLD 125
|
mm/vmstat.c:614: warning: "MAX_THRESHOLD" redefined
614 | #define MAX_THRESHOLD 0
|
mm/vmstat.c:172: note: this is the location of the previous definition
172 | #define MAX_THRESHOLD 125
|

Introduced by commit

5f6bac149e10 ("mm: vmstat: fix /proc/sys/vm/stat_refresh generating false warnings")

The preproccesor directives look like this:

#ifdef CONFIG_SMP
#define MAX_THRESHOLD 125
#ifdef CONFIG_HAVE_CMPXCHG_LOCAL
#else
#define MAX_THRESHOLD 0

So I guess the second MAX_THRESHOLD was put after the wrong #else?

--
Cheers,
Stephen Rothwell

Attachment: pgpp5JafJZ08Z.pgp
Description: OpenPGP digital signature