Re: [PATCH v5 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

From: David Miller
Date: Fri Jul 17 2020 - 15:40:12 EST


From: Weilong Chen <chenweilong@xxxxxxxxxx>
Date: Wed, 15 Jul 2020 20:58:10 +0800

> When vlan_newlink call register_vlan_dev fails, it might return error
> with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should
> free the memory. But currently rtnl_newlink only free the memory which
> state is NETREG_UNINITIALIZED.
...
> Fixes: cb626bf566eb ("net-sysfs: Fix reference count leak")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Weilong Chen <chenweilong@xxxxxxxxxx>

Applied and queued up for -stable, thanks.