Re: [PATCH 02/30] iio: adc: twl4030-madc: Remove set but unused variables 'len'

[Jonathan Cameron]

On Fri, 17 Jul 2020 17:55:10 +0100
Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/iio/adc/twl4030-madc.c: In function âtwl4030_madc_threaded_irq_handlerâ:
>  drivers/iio/adc/twl4030-madc.c:475:9: warning: variable âlenâ set but not used [-Wunused-but-set-variable]
>  475 | int i, len, ret;
>  | ^~~
> 
> Cc: Sebastian Reichel <sre@xxxxxxxxxx>
> Cc: J Keerthy <j-keerthy@xxxxxx>
> Cc: Mikko Ylinen <mikko.k.ylinen@xxxxxxxxx>
> Cc: Amit Kucheria <amit.kucheria@xxxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
Applied to the togreg branch of iio.git and pushed out as testing or the autobuilders
to play with them.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/twl4030-madc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c
> index 472b08f37feae..826d8295e9b3c 100644
> --- a/drivers/iio/adc/twl4030-madc.c
> +++ b/drivers/iio/adc/twl4030-madc.c
> @@ -472,7 +472,7 @@ static irqreturn_t twl4030_madc_threaded_irq_handler(int irq, void *_madc)
>  	struct twl4030_madc_data *madc = _madc;
>  	const struct twl4030_madc_conversion_method *method;
>  	u8 isr_val, imr_val;
> -	int i, len, ret;
> +	int i, ret;
>  	struct twl4030_madc_request *r;
>  
>  	mutex_lock(&madc->lock);
> @@ -504,8 +504,8 @@ static irqreturn_t twl4030_madc_threaded_irq_handler(int irq, void *_madc)
>  			continue;
>  		method = &twl4030_conversion_methods[r->method];
>  		/* Read results */
> -		len = twl4030_madc_read_channels(madc, method->rbase,
> -						 r->channels, r->rbuf, r->raw);
> +		twl4030_madc_read_channels(madc, method->rbase,
> +					   r->channels, r->rbuf, r->raw);
>  		/* Free request */
>  		r->result_pending = false;
>  		r->active = false;
> @@ -525,8 +525,8 @@ static irqreturn_t twl4030_madc_threaded_irq_handler(int irq, void *_madc)
>  			continue;
>  		method = &twl4030_conversion_methods[r->method];
>  		/* Read results */
> -		len = twl4030_madc_read_channels(madc, method->rbase,
> -						 r->channels, r->rbuf, r->raw);
> +		twl4030_madc_read_channels(madc, method->rbase,
> +					   r->channels, r->rbuf, r->raw);
>  		/* Free request */
>  		r->result_pending = false;
>  		r->active = false;