Re: [PATCH V6 6/6] clk: imx6sl: Fix build warning reported by kernel test robot

[Shawn Guo]

On Wed, Jul 15, 2020 at 06:00:17PM -0700, Stephen Boyd wrote:
> Quoting Anson Huang (2020-07-06 22:09:39)
> > Use readl_relaxed() instead of __raw_readl(), and use BIT(x)
> > instead of (1 << X) to fix below build warning reported by kernel
> > test robot:
> > 
> > drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit
> > value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
> >      while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK))
> > 
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > ---
> 
> The subject is poor. Please improve it so that it summarizes the change
> instead of the reaction to a warning from a robot.
> 
> > New patch.
> > ---
> >  drivers/clk/imx/clk-imx6sl.c | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> > 
> 
> This should come earlier in the series too so that the build warning
> doesn't come out before this patch is applied.

Anson,

Please update the series per request from Stephen.  I have dropped the
series from my branch.

Shawn