Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints

[Sameer Pujar]

On 7/20/2020 5:07 AM, Kuninori Morimoto wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Sameer
>
> > If a Codec port has multiple endpoints, only first endpoint gets parsed
> > and remaining are ignored. This can be fixed by removing 'dup_codec' flag
> > passed to graph_dai_link_of_dpcm() and thus it loops over all endpoints
> > of Codec. Similarly graph_count_dpcm() is updated as well.
> >
> > Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
> > ---
> >   sound/soc/generic/audio-graph-card.c | 28 +++++++++-------------------
> >   1 file changed, 9 insertions(+), 19 deletions(-)
> >
> > diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
> > index 1e20562..b1903f9 100644
> > --- a/sound/soc/generic/audio-graph-card.c
> > +++ b/sound/soc/generic/audio-graph-card.c
> > @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top,
> >   static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv,
> >                                  struct device_node *cpu_ep,
> >                                  struct device_node *codec_ep,
> > -                               struct link_info *li,
> > -                               int dup_codec)
> > +                               struct link_info *li)
> This patch breaks DPCM connection which is used for MIXer

Could you please elaborate a bit more as to what is broken with this? 
The problem I am trying to solve here is to have multiple endpoints for 
Codec port.

> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto