Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver
From: Philipp Zabel
Date: Mon Jul 20 2020 - 05:38:01 EST
Hi Rajesh,
On Mon, 2020-07-20 at 12:04 +0530, Rajesh Gumasta wrote:
> +
> + tdma->rst = devm_reset_control_get(&pdev->dev, "gpcdma");
Please use devm_reset_control_get_exclusive() directly.
> + if (IS_ERR(tdma->rst)) {
> + dev_err(&pdev->dev, "Missing controller reset\n");
You might want to suppress this message if the error is EPROBE_DEFER.
> + return PTR_ERR(tdma->rst);
> + }
> + reset_control_reset(tdma->rst);
regards
Philipp