Re: [PATCH V2] soc: qcom: geni: Fix NULL pointer dereference

[Sai Prakash Ranjan]

On 2020-07-20 15:06, Akash Asthana wrote:
> pdev struct doesn't exists for the devices whose status are disabled
> from DT node, in such cases NULL is returned from 
> 'of_find_device_by_node'
> Later when we try to get drvdata from pdev struct NULL pointer 
> dereference
> is triggered.
>
> Add a NULL check for return values to fix the issue.
>
> We were hitting this issue when one of QUP is disabled.
>
> Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to
> fix earlycon crash")
> Reported-by: Sai Prakash Ranjan <saipraka@xxxxxxxxxxxxxx>
> Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> Signed-off-by: Akash Asthana <akashast@xxxxxxxxxxxxxx>

Nit: my codeaurora mail address is <saiprakash.ranjan@xxxxxxxxxxxxxx>.
I don't think you have to resend for this small change, hopefully 
maintainers
are ok to fix this when applying.

Reported-by: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx>
Tested-by: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx>

-Sai

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation