RE: [PATCH v5] rtc: rtc-ds1374: wdt: Use watchdog core for watchdog part

From: Johnson CH Chen (éæå)
Date: Mon Jul 20 2020 - 06:44:47 EST


Hi Alexandre,

> > v4->v5:
> > - Fix reported build error by replacing RTC_DRV_DS1374_WDT with
> > WATCHDOG_CORE
> >
>
> This is not the correct solution as this will remove the alarm functionality for
> anyone enabling WATCHDOG. I already submitted a proper fix.
>

It's an appropriate and better solution. Thanks!

RTC_DRV_DS1374_WDT still should select WATCHDOG_CORE to avoid build error if WATCHDOG_CORE is set to "m", and it should be depended on RTC_DRV_DS1374 and WATCHDOG.

> > v3->v4:
> > - Fix coding styles
> > - Remove dev_info() in ds1374_wdt_settimeout()
> > - Fix missing error check
> >
>
> --

Best regards,
Johnson