Re: [PATCH RFC] rcu/segcblist: Add counters to segcblist datastructure

From: Davidlohr Bueso
Date: Mon Jul 20 2020 - 10:41:20 EST


On Sat, 18 Jul 2020, Joel Fernandes (Google) wrote:

+/* Move from's segment length to to's segment. */
+static void rcu_segcblist_move_seglen(struct rcu_segcblist *rsclp, int from, int to)
+{
+ long len = rcu_segcblist_get_seglen(rsclp, from);
+
+ if (!len || from == to)
+ return;

Nit: You probably wanna do the parameter sanity checks before the
atomic_read.

Thanks,
Davidlohr