Re: [PATCH 7/7] soc: imx8: Add the SC SECVIO driver
From: kernel test robot
Date: Mon Jul 20 2020 - 11:01:23 EST
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linux/master linus/master v5.8-rc6]
[cannot apply to shawnguo/for-next next-20200720]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/franck-lenormand-oss-nxp-com/Add-support-of-SECVIO-from-SNVS-on-iMX8q-x/20200720-171044
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> drivers/soc/imx/secvio/imx-secvio-sc.c:200:5: warning: no previous prototype for 'int_imx_secvio_sc_check_state' [-Wmissing-prototypes]
200 | int int_imx_secvio_sc_check_state(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/imx/secvio/imx-secvio-sc.c: In function 'int_imx_secvio_sc_disable_irq':
>> drivers/soc/imx/secvio/imx-secvio-sc.c:524:29: warning: variable 'data' set but not used [-Wunused-but-set-variable]
524 | struct imx_secvio_sc_data *data;
| ^~~~
drivers/soc/imx/secvio/imx-secvio-sc.c: At top level:
>> drivers/soc/imx/secvio/imx-secvio-sc.c:630:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
630 | const static struct file_operations imx_secvio_sc_fops = {
| ^~~~~
--
>> drivers/soc/imx/secvio/imx-secvio-debugfs.c:45:5: warning: no previous prototype for 'fuse_reader' [-Wmissing-prototypes]
45 | int fuse_reader(struct device *dev, u32 id, u32 *value, u8 mul)
| ^~~~~~~~~~~
>> drivers/soc/imx/secvio/imx-secvio-debugfs.c:78:5: warning: no previous prototype for 'snvs_reader' [-Wmissing-prototypes]
78 | int snvs_reader(struct device *dev, u32 id, u32 *value, u8 mul)
| ^~~~~~~~~~~
>> drivers/soc/imx/secvio/imx-secvio-debugfs.c:129:5: warning: no previous prototype for 'snvs_dgo_reader' [-Wmissing-prototypes]
129 | int snvs_dgo_reader(struct device *dev, u32 id, u32 *value, u8 mul)
| ^~~~~~~~~~~~~~~
--
>> drivers/soc/imx/secvio/imx-secvio-audit.c:23:5: warning: no previous prototype for 'report_to_audit_notify' [-Wmissing-prototypes]
23 | int report_to_audit_notify(struct notifier_block *nb, unsigned long status,
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/int_imx_secvio_sc_check_state +200 drivers/soc/imx/secvio/imx-secvio-sc.c
189
190 /**
191 * int_imx_secvio_sc_check_state() - Get the state and call chain of notifier
192 * if there is a status
193 *
194 * @dev: secvio device
195 *
196 * Return:
197 * 0 - OK
198 * < 0 - error.
199 */
> 200 int int_imx_secvio_sc_check_state(struct device *dev)
201 {
202 struct secvio_sc_notifier_info info = {0};
203 int ret = 0;
204
205 ret = int_imx_secvio_sc_get_state(dev, &info);
206 if (ret) {
207 dev_err(dev, "Failed to get secvio state\n");
208 goto exit;
209 }
210
211 /* Call chain of CB registered to this module if status detected */
212 if (info.hpsvs || info.lps || info.lptds)
213 if (imx_secvio_sc_notifier_call_chain(&info))
214 dev_warn(dev,
215 "Issues when calling the notifier chain\n");
216
217 exit:
218 return ret;
219 }
220
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip