Re: [PATCH 05/24] fs: move the putname from filename_lookup to the callers

From: Al Viro
Date: Mon Jul 20 2020 - 14:11:14 EST


On Mon, Jul 20, 2020 at 05:58:43PM +0200, Christoph Hellwig wrote:
> This allows reusing the struct filename for retries, and will also allow
> pushing the getname up the stack for a few places to allower for better
> handling of kernel space filenames.

You are complicating the callers for no good reason. NAK. The same goes
for the previous patch in the series.

Keep the cleanup rules simple. Sure, I understand wanting to avoid
special rules for early bootstrap, but that's a corner case; don't
make fs/namei.c harder to follow.