Re: [PATCH v3 4/5] LSM: Define SELinux function to measure security state

[Lakshmi Ramasubramanian]

On 7/20/20 10:49 AM, Stephen Smalley wrote:

> > > Looks like the template used is ima-ng which doesn't include the
> > > measured buffer. Please set template to "ima-buf" in the policy.
> > >
> > > For example,
> > > measure func=LSM_STATE template=ima-buf
> >
> > It seems like one shouldn't need to manually specify it if it is the
> > only template that yields a useful result for the LSM_STATE function?
>
> Actually, if we used ima-ng template for selinux-policy-hash, then
> instead of needing to hash the policy
> first and passing the hash to IMA, we could just pass the policy as
> the buffer and IMA would take care of the hashing, right?

That is correct.

The IMA hook I've added to measure LSM structures is a generic one that 
can be used by any security module (SM). I feel it would be better to 
not have policy or state or any such SM specific logic in IMA, but leave 
that to the individual SM to handle.

What do you think?

> And we only need to use ima-buf for the selinux-state if we want the
> measurement list to include the string value that
> was hashed; if we just want to compare against a known-good, it would
> suffice to use ima-ng for it as well, right?

 -lakshmi