Re: [GIT PULL] VFIO fix for v5.8-rc7

[Alex Williamson]

On Mon, 20 Jul 2020 13:33:29 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, Jul 20, 2020 at 7:34 AM Alex Williamson
> <alex.williamson@xxxxxxxxxx> wrote:
> >
> > VFIO fixes for v5.8-rc7
> >
> >  - Fix race with eventfd ctx cleared outside of mutex (Zeng Tao)  
> 
> Why does this take and then re-take the lock immediately? That just
> looks insane.
> 
> I realize that this isn't likely to be a performance-critical path,
> but this is a basic source cleanliness issue. Doing silly things is
> silly, and shouldn't be done, even if they don't matter.

Yup, it's silly.  Cornelia identified the same during review and I let
it slide after some counter arguments by the submitter.  I see this got
merged, so I'll post a cleanup for v5.9.  Thanks for the input,

Alex