Re: [PATCH] firmware: ti_sci: Replace HTTP links with HTTPS ones

[Alexander A. Klimov]

Am 20.07.20 um 09:32 schrieb Tero Kristo:
> Hi Alexander,
Hi,

> One comment below.
>
> On 18/07/2020 13:55, Alexander A. Klimov wrote:
> > Rationale:
> > Reduces attack surface on kernel devs opening the links for MITM
> > as HTTPS traffic is much harder to manipulate.
> >
> > Deterministic algorithm:
> > For each file:
> > ÂÂ If not .svg:
> > ÂÂÂÂ For each line:
> > ÂÂÂÂÂÂ If doesn't contain `\bxmlns\b`:
> > ÂÂÂÂÂÂÂÂ For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> > ÂÂÂÂÂ If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> > ÂÂÂÂÂÂÂÂÂÂÂÂ If both the HTTP and HTTPS versions
> > ÂÂÂÂÂÂÂÂÂÂÂÂ return 200 OK and serve the same content:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Replace HTTP with HTTPS.
> >
> > Signed-off-by: Alexander A. Klimov <grandmaster@xxxxxxxxxxxx>
> > ---
> > Â Continuing my work started at 93431e0607e5.
> > Â See also: git log --oneline '--author=Alexander A. Klimov 
> > <grandmaster@xxxxxxxxxxxx>' v5.7..master
> >
> > Â If there are any URLs to be removed completely
> > Â or at least not (just) HTTPSified:
> > Â Just clearly say so and I'll *undo my change*.
> > Â See also: https://lkml.org/lkml/2020/6/27/64
> >
> > Â If there are any valid, but yet not changed URLs:
> > Â See: https://lkml.org/lkml/2020/6/26/837
> >
> > Â If you apply the patch, please let me know.
> >
> >
> > Â .../devicetree/bindings/interrupt-controller/ti,sci-intr.txtÂÂÂ | 2 +-
> > Â drivers/firmware/ti_sci.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 2 +-
> > Â drivers/firmware/ti_sci.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 2 +-
> > Â drivers/irqchip/irq-ti-sci-inta.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 2 +-
> > Â drivers/irqchip/irq-ti-sci-intr.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 2 +-
> > Â drivers/reset/reset-ti-sci.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 2 +-
> > Â include/linux/soc/ti/ti_sci_inta_msi.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 2 +-
> > Â include/linux/soc/ti/ti_sci_protocol.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 2 +-
> > Â 8 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt 
> > b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
> > index 1a8718f8855d..178fca08278f 100644
> > --- 
> > a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
> > +++ 
> > b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
> > @@ -55,7 +55,7 @@ Required Properties:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ corresponds to a range of host irqs.
> > Â For more details on TISCI IRQ resource management refer:
> > -http://downloads.ti.com/tisci/esd/latest/2_tisci_msgs/rm/rm_irq.html
> > +https://downloads.ti.com/tisci/esd/latest/2_tisci_msgs/rm/rm_irq.html
> > Â Example:
> > Â --------
> > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> > index 4126be9e3216..53cee17d0115 100644
> > --- a/drivers/firmware/ti_sci.c
> > +++ b/drivers/firmware/ti_sci.c
> > @@ -2,7 +2,7 @@
> > Â /*
> > ÂÂ * Texas Instruments System Control Interface Protocol Driver
> > ÂÂ *
> > - * Copyright (C) 2015-2016 Texas Instruments Incorporated - 
> > http://www.ti.com/
> > + * Copyright (C) 2015-2016 Texas Instruments Incorporated - 
> > https://www.ti.com/
> > ÂÂ *ÂÂÂ Nishanth Menon
> > ÂÂ */
> > diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h
> > index f0d068c03944..57cd04062994 100644
> > --- a/drivers/firmware/ti_sci.h
> > +++ b/drivers/firmware/ti_sci.h
> > @@ -6,7 +6,7 @@
> > ÂÂ * The system works in a message response protocol
> > ÂÂ * See: http://processors.wiki.ti.com/index.php/TISCI for details
>
> ^^^^
>
> You should probably replace that one as well to be https while doing the 
> rest of the changes, even though the wiki is being deprecated during 
> this year.
Don't worry, I'll run another scan anyway to cover newly added URLs.
Do you require this additional change for applying this patch?

> -Tero
>
> > ÂÂ *
> > - * Copyright (C)Â 2015-2016 Texas Instruments Incorporated - 
> > http://www.ti.com/
> > + * Copyright (C)Â 2015-2016 Texas Instruments Incorporated - 
> > https://www.ti.com/
> > ÂÂ */
> > Â #ifndef __TI_SCI_H
> > diff --git a/drivers/irqchip/irq-ti-sci-inta.c 
> > b/drivers/irqchip/irq-ti-sci-inta.c
> > index 7e3ebf6ed2cd..85de19fe9b6e 100644
> > --- a/drivers/irqchip/irq-ti-sci-inta.c
> > +++ b/drivers/irqchip/irq-ti-sci-inta.c
> > @@ -2,7 +2,7 @@
> > Â /*
> > ÂÂ * Texas Instruments' K3 Interrupt Aggregator irqchip driver
> > ÂÂ *
> > - * Copyright (C) 2018-2019 Texas Instruments Incorporated - 
> > http://www.ti.com/
> > + * Copyright (C) 2018-2019 Texas Instruments Incorporated - 
> > https://www.ti.com/
> > ÂÂ *ÂÂÂ Lokesh Vutla <lokeshvutla@xxxxxx>
> > ÂÂ */
> > diff --git a/drivers/irqchip/irq-ti-sci-intr.c 
> > b/drivers/irqchip/irq-ti-sci-intr.c
> > index 59d51a20bbd8..5ea148faf2ab 100644
> > --- a/drivers/irqchip/irq-ti-sci-intr.c
> > +++ b/drivers/irqchip/irq-ti-sci-intr.c
> > @@ -2,7 +2,7 @@
> > Â /*
> > ÂÂ * Texas Instruments' K3 Interrupt Router irqchip driver
> > ÂÂ *
> > - * Copyright (C) 2018-2019 Texas Instruments Incorporated - 
> > http://www.ti.com/
> > + * Copyright (C) 2018-2019 Texas Instruments Incorporated - 
> > https://www.ti.com/
> > ÂÂ *ÂÂÂ Lokesh Vutla <lokeshvutla@xxxxxx>
> > ÂÂ */
> > diff --git a/drivers/reset/reset-ti-sci.c b/drivers/reset/reset-ti-sci.c
> > index bf68729ab729..b799aefad547 100644
> > --- a/drivers/reset/reset-ti-sci.c
> > +++ b/drivers/reset/reset-ti-sci.c
> > @@ -1,7 +1,7 @@
> > Â /*
> > ÂÂ * Texas Instrument's System Control Interface (TI-SCI) reset driver
> > ÂÂ *
> > - * Copyright (C) 2015-2017 Texas Instruments Incorporated - 
> > http://www.ti.com/
> > + * Copyright (C) 2015-2017 Texas Instruments Incorporated - 
> > https://www.ti.com/
> > ÂÂ *ÂÂÂ Andrew F. Davis <afd@xxxxxx>
> > ÂÂ *
> > ÂÂ * This program is free software; you can redistribute it and/or modify
> > diff --git a/include/linux/soc/ti/ti_sci_inta_msi.h 
> > b/include/linux/soc/ti/ti_sci_inta_msi.h
> > index 11fb5048f5f6..e3aa8b14612e 100644
> > --- a/include/linux/soc/ti/ti_sci_inta_msi.h
> > +++ b/include/linux/soc/ti/ti_sci_inta_msi.h
> > @@ -2,7 +2,7 @@
> > Â /*
> > ÂÂ * Texas Instruments' K3 TI SCI INTA MSI helper
> > ÂÂ *
> > - * Copyright (C) 2018-2019 Texas Instruments Incorporated - 
> > http://www.ti.com/
> > + * Copyright (C) 2018-2019 Texas Instruments Incorporated - 
> > https://www.ti.com/
> > ÂÂ *ÂÂÂ Lokesh Vutla <lokeshvutla@xxxxxx>
> > ÂÂ */
> > diff --git a/include/linux/soc/ti/ti_sci_protocol.h 
> > b/include/linux/soc/ti/ti_sci_protocol.h
> > index 9531ec823298..0fc452dd96d4 100644
> > --- a/include/linux/soc/ti/ti_sci_protocol.h
> > +++ b/include/linux/soc/ti/ti_sci_protocol.h
> > @@ -2,7 +2,7 @@
> > Â /*
> > ÂÂ * Texas Instruments System Control Interface Protocol
> > ÂÂ *
> > - * Copyright (C) 2015-2016 Texas Instruments Incorporated - 
> > http://www.ti.com/
> > + * Copyright (C) 2015-2016 Texas Instruments Incorporated - 
> > https://www.ti.com/
> > ÂÂ *ÂÂÂ Nishanth Menon
> > ÂÂ */
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. 
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki