Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

From: David Miller
Date: Mon Jul 20 2020 - 19:27:29 EST


From: Sriram Krishnan <srirakr2@xxxxxxxxx>
Date: Mon, 20 Jul 2020 22:15:51 +0530

> + if (skb->protocol == htons(ETH_P_8021Q)) {
> + u16 vlan_tci = 0;
> + skb_reset_mac_header(skb);

Please place an empty line between basic block local variable declarations
and actual code.

> + netdev_err(net,"Pop vlan err %x\n",pop_err);

A space is necessary before "pop_err".