Re: [PATCH net-next v2 1/2] hinic: add support to handle hw abnormal event

[luobin (L)]

On 2020/7/21 2:13, Jakub Kicinski wrote:
> On Sat, 18 Jul 2020 16:58:29 +0800 Luo bin wrote:
>> add support to handle hw abnormal event such as hardware failure,
>> cable unplugged,link error
>>
>> Signed-off-by: Luo bin <luobin9@xxxxxxxxxx>
>> ---
>> V1~V2: add link extended state
>> V0~V1: fix auto build test WARNING
> 
> I don't understand what you think devlink health is missing.
> 
> If it is really missing some functionality you require you have to work
> on extending it.
> 
> Dumping error event state into kernel logs when we have specific
> infrastructure built to address this sort of needs won't fly.
> .
> 
Okay, I'll try to implement these functionality based on devlink health.