Re: [PATCH] cxgb4: add missing release on skb in uld_send()

[David Miller]

From: Navid Emamdoost <navid.emamdoost@xxxxxxxxx>
Date: Sat, 18 Jul 2020 00:18:43 -0500

> diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
> index 32a45dc51ed7..d8c37fd4b808 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
> @@ -2938,6 +2938,7 @@ static inline int uld_send(struct adapter *adap, struct sk_buff *skb,
>  	txq_info = adap->sge.uld_txq_info[tx_uld_type];
>  	if (unlikely(!txq_info)) {
>  		WARN_ON(true);
> +		consume_skb(skb);
>  		return NET_XMIT_DROP;
>  	}
>  

This is a packet drop so kfree_skb() is more appropriate here.