Re: [PATCH v5 3/4] power: supply: core: add wireless signal strength property

[Greg KH]

On Tue, Jul 21, 2020 at 01:59:36PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xxxxxxxxxx>
> 
> reports wireless signal strength.
> The value show degree of coupling between tx and rx.
> 
> Signed-off-by: Qiwu Huang <huangqiwu@xxxxxxxxxx>
> ---
>  Documentation/ABI/testing/sysfs-class-power | 10 ++++++++++
>  drivers/power/supply/power_supply_sysfs.c   |  1 +
>  include/linux/power_supply.h                |  1 +
>  3 files changed, 12 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 03ab449fae8a..75ec7de2fe78 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -757,3 +757,13 @@ Description:
>  			13: ADAPTER_VOICE_BOX,
>  			14: ADAPTER_PRIVATE_PD_50W.
>  
> +What:		/sys/class/power_supply/<supply_name>/signal_strength
> +Date:		Jul 2020
> +Contact:	Fei Jiang <jiangfei1@xxxxxxxxxx>
> +Description:
> +		In PING phase, RX transmits a signal strength packet as the first

What does "PING phase" mean?

Other than that, seems sane to me, thanks for the changes.

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>