Re: [PATCH V3] clk: vc5: Add memory check to prevent oops

[Stephen Boyd]

Quoting Adam Ford (2020-07-16 05:26:20)
> When getting the names of the child nodes, kasprintf is used to
> allocate memory which is used to create the string for the node
> name.  Unfortunately, there is no memory check to determine
> if this allocation fails, it may cause an error when trying
> to get child node name.
> 
> This patch will check if the memory allocation fails, and returns
> and -ENOMEM error instead of blindly moving on.
> 
> Fixes: 260249f929e8 ("clk: vc5: Enable addition output configurations of the Versaclock")
> 
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
> Reviewed-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
> ---
> V3:   Fix spelling error, and use the style of checking (!variable) instead of
>       (variable == NULL)
> 
> V2:   Fix an issue where a goto was going to use an unitialized variable.

Is the patch from Colin also needed?
https://lore.kernel.org/r/20200625132736.88832-1-colin.king@xxxxxxxxxxxxx