Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

[Felipe Balbi]

Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx> writes:

> On 7/15/2020 1:32 PM, Lee Jones wrote:
>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>> value.  Looks like this has been broken since
>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>> 
>> Also fixes the following W=1 warning:
>> 
>>   drivers/usb/dwc2/gadget.c: In function âdwc2_gadget_wkup_alert_handlerâ:
>>   drivers/usb/dwc2/gadget.c:259:6: warning: variable âgintmsk2â set but not used [-Wunused-but-set-variable]
>>   259 | u32 gintmsk2;
>>   | ^~~~~~~~
>> 
>> Cc: Minas Harutyunyan <hminas@xxxxxxxxxxxx>
>> Cc: Ben Dooks <ben@xxxxxxxxxxxx>
>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
>> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> Acked-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx>

Should I apply the entire series or only 1/8?

-- 
balbi

Attachment: signature.asc
Description: PGP signature