Re: [PATCH v3] lib: kunit: Provides a userspace memory context when tests are compiled as module

From: Brendan Higgins
Date: Tue Jul 21 2020 - 19:53:06 EST


On Tue, Jul 21, 2020 at 10:40 AM Vitor Massaru Iha <vitor@xxxxxxxxxxx> wrote:
>
> KUnit test cases run on kthreads, and kthreads don't have an
> adddress space (current->mm is NULL), but processes have mm.
>
> The purpose of this patch is to allow to borrow mm to KUnit kthread
> after userspace is brought up, because we know that there are processes
> running, at least the process that loaded the module to borrow mm.
>
> This allows, for example, tests such as user_copy_kunit, which uses
> vm_mmap, which needs current->mm.
>
> Signed-off-by: Vitor Massaru Iha <vitor@xxxxxxxxxxx>

Isn't this a dependency for the test_user_copy? Also, don't we also
need the change that makes kunit_tool build modules? It seems like you
should put these together in a patchset like you did before. If not,
you should at least reference the dependencies in each patch.