Re: [PATCH v2] drivers/net/wan/x25_asy: Fix to make it work

From: David Miller
Date: Tue Jul 21 2020 - 21:30:24 EST


From: Xie He <xie.he.0141@xxxxxxxxx>
Date: Thu, 16 Jul 2020 16:44:33 -0700

> This driver is not working because of problems of its receiving code.
> This patch fixes it to make it work.
>
> When the driver receives an LAPB frame, it should first pass the frame
> to the LAPB module to process. After processing, the LAPB module passes
> the data (the packet) back to the driver, the driver should then add a
> one-byte pseudo header and pass the data to upper layers.
>
> The changes to the "x25_asy_bump" function and the
> "x25_asy_data_indication" function are to correctly implement this
> procedure.
>
> Also, the "x25_asy_unesc" function ignores any frame that is shorter
> than 3 bytes. However the shortest frames are 2-byte long. So we need
> to change it to allow 2-byte frames to pass.
>
> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Martin Schiller <ms@xxxxxxxxxx>
> Signed-off-by: Xie He <xie.he.0141@xxxxxxxxx>

Applied, thank you.