Re: [PATCH v1 2/2] {topost} scsi: libsas: check link status at ATA prereset() ops

From: Jason Yan
Date: Wed Jul 22 2020 - 06:31:41 EST



在 2020/7/22 17:04, Luo Jiaxing 写道:
We found out that libata will retry reset even if SATA disk is unpluged. We
should report offline to libata to avoid meaningless reset on the disk.
Libata provide an ops of prereset() for this purpose, it was called by
ata_eh_reset() only and used to decide whether to skip reset base on the
return value of it.

We check status of phy and disk at prereset(). If disk is already offline
or phy is disabled, we return -ENOENT to libata to skip disk reset.

As prereset() should be best-effort, we should continue to try disk reset
beyond the situation we mentioned before.

Signed-off-by: Luo Jiaxing <luojiaxing@xxxxxxxxxx>
Reviewed-by: John Garry <john.garry@xxxxxxxxxx>
---
drivers/scsi/libsas/sas_ata.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)


The same as the first one, after fix the subject:

Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>